Fix outerloop issues #8687
Merged
Fix outerloop issues #8687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- eng/Testing.targets: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/tests-outerloop.yml:96
- The log directory path has been updated but the artifact retention step still references the old base path. Ensure that the new log directory is used consistently throughout the workflow for proper log collection.
$logDirectory = "${{ github.workspace }}/artifacts/TestResults"
.github/workflows/tests-outerloop.yml:175
- The artifact retention step uses a path that includes an extra 'log' segment which may be inconsistent with the new $logDirectory path. Consider updating this path to match the change made in the run step.
${{ github.workspace }}/artifacts/log/TestResults/*/*.trx
|
Here's a test outerloop run - neither the Playground tests nor E2E tests are run on Windows any longer. |
068d348 to
799a9d0
Compare
RussKie
commented
Apr 10, 2025
| @@ -50,7 +50,8 @@ | |||
| <SkipTests>true</SkipTests> | |||
|
|
|||
| <!-- Only run tests if the build is running on GitHub Actions --> | |||
| <SkipTests Condition=" '$(IsGitHubActionsRunner)' == 'true' and '$(RunOnGithubActions)' == 'true' ">false</SkipTests> | |||
| <SkipTests Condition=" '$(IsGitHubActionsRunner)' == 'true' and '$(BuildOs)' == 'windows' and '$(RunOnGithubActionsWindows)' == 'true' ">false</SkipTests> | |||
| <SkipTests Condition=" '$(IsGitHubActionsRunner)' == 'true' and '$(BuildOs)' != 'windows' and '$(RunOnGithubActionsLinux)' == 'true' ">false</SkipTests> | |||
|
|
|||
| <!-- Only run tests if the build is running on Helix infra --> | |||
| <SkipTests Condition=" '$(IsAzdoHelixRunner)' == 'true' and '$(RunOnAzdoHelix)' == 'true' ">false</SkipTests> | |||
There was a problem hiding this comment.
The issue affects only the GHA, I don't want to upset and break the AzDO builds (I tried changing the other properties, and that led to failed build in AzDO).
We can look at the AzDO separation later.
1. Take build agent OS in account when running tests Addresses #8498 (comment) 2. Read trx from correct location Resolves #8683
799a9d0 to
54dc22e
Compare
radical
reviewed
Apr 10, 2025
radical
reviewed
Apr 10, 2025
Co-authored-by: Ankit Jain <radical@gmail.com>
RussKie
added a commit
to RussKie/aspire
that referenced
this pull request
Apr 15, 2025
RussKie
added a commit
to RussKie/aspire
that referenced
this pull request
Apr 15, 2025
RussKie
added a commit
to RussKie/aspire
that referenced
this pull request
Apr 16, 2025
RussKie
added a commit
to RussKie/aspire
that referenced
this pull request
Apr 16, 2025
RussKie
added a commit
to RussKie/aspire
that referenced
this pull request
Apr 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take build agent OS in account when running tests
Addresses Migrate from VSTest to Microsoft.Testing.Platform #8498 (comment)
Read trx from correct location
Resolves [CI] Outerloop tests workflow not collecting trx files in artifacts #8683