8000 [tests] Re-enable some quarantined tests that haven't been failing by radical · Pull Request #8615 · dotnet/aspire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[tests] Re-enable some quarantined tests that haven't been failing #8615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 8, 2025
Merged

[tests] Re-enable some quarantined tests that haven't been failing #8615

merged 4 commits into from
Apr 8, 2025

Conversation

radical
Copy link
Member
@radical radical commented Apr 8, 2025 •
edited
Loading

The following issues are for tests that haven't failed in the last ~50 runs of the Outerloop Tests workflow.

Fixes #7930
Fixes #7943
Fixes #8103
Fixes #8192
Fixes #8200
Fixes #8326
Fixes #8400
Fixes #8511
Fixes #8512
Fixes #8513
Fixes #8514

Also, Re-enable some tests in Aspire.Hosting.Tests.DistributedApplicationTests

All these tests were using the same issue url. And haven't failed
recently in github actions.

Issue: #4651

Bump default test session timeout from 10mins to 15mins

Prompted by Aspire.Hosting.Tests taking longer.

@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Apr 8, 2025
Copilot
Copilot AI reviewed Apr 8, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

radical added 2 commits April 8, 2025 02:06
@radical
fix build
072c8a9
@radical
Re-enable some tests in Aspire.Hosting.Tests.DistributedApplicationTests
36b583c 
All these tests were using the same issue url. And haven't failed
recently in github actions.

Issue: dotnet#4651
RussKie
RussKie approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor
@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@RussKie RussKie added area-engineering-systems infrastructure helix infra engineering repo stuff and removed area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication labels Apr 8, 2025
@radical radical enabled auto-merge (squash) April 8, 2025 07:10
@radical
Copy link
Member Author
radical commented Apr 8, 2025

Aspire.Hosting.Tests are taking longer than 10minutes to run.

Aborting test run: test run timeout of 600000 milliseconds exceeded.

Test Run Aborted.
Total tests: Unknown
     Passed: 574
 Total time: 10.0023 Minutes

@radical
Aspire.Hosting.Tests is taking longer than 10mins to run. Bump the se…
71917c1 
…ssion timeout for Integration tests to 15mins
@radical
Copy link
Member Author
radical commented Apr 8, 2025

Bumped the default session timeout to 15mins.

@radical radical merged commit f9035bc into dotnet:main Apr 8, 2025
175 checks passed
@radical radical deleted the re-enable-quarantined-tests branch April 8, 2025 07:42
This was referenced Apr 8, 2025
Merged
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@RussKie RussKie RussKie approved these changes

@danmoseley danmoseley Awaiting requested review from danmoseley

@joperezr joperezr Awaiting requested review from joperezr

@mitchdenny mitchdenny Awaiting requested review from mitchdenny mitchdenny is a code owner

@ReubenBond ReubenBond Awaiting requested review from ReubenBond ReubenBond is a code owner

Assignees
No one assigned
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test: WithHttpCommand_CallsGetResponseCallback_AfterSendingRequest Flaky test: WithHttpCommandTests.WithHttpCommand_CallsPrepareRequestCallback_BeforeSendingRequest ResourcesWithHealthCheck_StopsAndRestartsMonitoringWithResource flaky [Failing test] Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests.AppBar_Change_Theme_ReloadPage Failing test - Windows/GA - Aspire.Hosting.Testing.Tests.TestingBuilderTests.ArgsPropagateToAppHostConfiguration
[Failing test]: ResourceHealthCheckServiceTests.ResourcesWithHealthCheck_CreationErrorIsReported [Failing test]: Aspire.Hosting.Tests.OperationModesTests.VerifyBackwardsCompatableRunModeInvocation [Flaky test] Aspire.Hosting.Tests.SlimTestProgramTests.TestPortOnEndpointAnnotationAndAllocatedEndpointAnnotationMatch [failing test] Aspire.Hosting.Tests.SlimTestProgramTests.TestPortOnEndpointAnnotationAndAllocatedEndpointAnnotationMatchForReplicatedServices [failing test] Aspire.Hosting.Tests.SlimTestProgramTests.TestProjectStartsAndStopsCleanly
2 participants
@radical @RussKie
0