[outerloop] Run with -ci to match the other test runs on CI
#8526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will also cause Playwright to be correctly installed for Dashboard tests. Fixes dotnet#8496
There was a problem hiding this comment.
Pull Request Overview
This PR updates the outerloop test workflow to run tests with the -ci flag for consistency with other CI test runs and ensure proper installation of Playwright for Dashboard tests.
- Added the -ci flag to the BUILD_SCRIPT invocation in the outerloop workflow.
Comments suppressed due to low confidence (1)
.github/workflows/tests-outerloop.yml:50
- Ensure that the positioning of the '-ci' flag is compatible with the BUILD_SCRIPT command parsing logic. If the flag order matters, consider verifying that placing '-ci' before '-restore' does not affect the expected behavior.
${{ env.BUILD_SCRIPT }} -projects ${{ github.workspace }}/tests/Shared/SolutionTests.proj -ci -restore -build -test -c Release /p:RunQuarantinedTests=true /bl:${{ github.workspace }}/artifacts/log/Release/test-quarantined.binlog
|
Validation run of Outerloop workflow which shows that the Playwright (`Aspire.Dashboard.Tests.Integration.Playwright.*) are running: https://github.com/dotnet/aspire/actions/runs/14250579409/job/39942112756 |
danmoseley
approved these changes
Apr 3, 2025
joperezr
approved these changes
Apr 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will also cause Playwright to be correctly installed for Dashboard
tests.
Fixes #8496