[tests] Quarantine additional tests for issues open against them #8508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5287b3b to
b7df446
Compare
These tests have issues open for them, but tests aren't marked with QuarantinedTest attribute.
cfcb36e to
b56bf21
Compare
…ResultsInExpectedResultForHttpMethod
There was a problem hiding this comment.
Pull Request Overview
This PR quarantines several tests that have been identified as flaky or problematic, helping to isolate failing tests while issues are addressed. Key changes include:
- Adding a [QuarantinedTest] attribute to tests in WithHttpCommandTests.cs, OperationModesTests.cs, MSBuildTests.cs, MySqlFunctionalTests.cs, and AzureCosmosDBEmulatorFunctionalTests.cs.
- Replacing an [ActiveIssue] attribute with a [QuarantinedTest] attribute in MSBuildTests.cs.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs | Added quarantined test attribute to a theory test. |
| tests/Aspire.Hosting.Tests/OperationModesTests.cs | Added quarantined test attribute to a fact test for legacy run mode verification. |
| tests/Aspire.Hosting.Tests/MSBuildTests.cs | Changed attribute from ActiveIssue to QuarantinedTest to quarantine a test concerning project references. |
| tests/Aspire.Hosting.MySql.Tests/MySqlFunctionalTests.cs | Added quarantined test attribute on a functional test using Docker. |
| tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs | Added quarantined test attribute, but the URL format appears to be inconsistent with the other tests. |
tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs
Outdated
Show resolved
Hide resolved
…alTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
RussKie
approved these changes
Apr 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are tests that have corresponding
flaky-testissues but haven't been quarantined.Also, quarantine a new flaky test - #8514 .