8000 Refactor AzurePublisher to enable usage in downstream publishers by sunandabalu · Pull Request #8507 · dotnet/aspire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor AzurePublisher to enable usage in downstream publishers #8507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 4, 2025
Merged

Refactor AzurePublisher to enable usage in downstream publishers #8507

merged 8 commits into from
Apr 4, 2025

Conversation

sunandabalu
Copy link
Member
@sunandabalu sunandabalu commented Apr 2, 2025 •
edited by eerhardt
Loading

Description

Few refactoring changes to AzurePublisher to enable usage in downstream publishers:

  • Refactor the logic in AzurePublisher to a new public AzurePublishingContext class.
  • refactor code in AzurePublisher.PublishAsync to AzurePublishingContext and capture bicep compilation data that is thrown away in the existing AzurePublisher.PublishAsync method

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship. (although it is under Experimental attribute)
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Apr 2, 2025
@davidfowl
Copy link
Member

this PR doesn't need a playground sample.

@eerhardt eerhardt marked this pull request as ready for review April 4, 2025 21:34
@eerhardt
Copy link
Member
eerhardt commented Apr 4, 2025

Thanks, @sunandabalu, for the great start on this PR! I tweaked it a little bit and added a test for the new functionality. I believe this PR is ready for review.

Note I took an approach with the public API for now. We can tweak the public API as we go and learn more. It is currently marked as [Experimental], so we can update it in the future.

@eerhardt eerhardt merged commit 8d9c32f into main Apr 4, 2025
174 checks passed
@eerhardt eerhardt deleted the subal-azpublish branch April 4, 2025 22:22
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley left review comments

@eerhardt eerhardt eerhardt left review comments

@davidfowl davidfowl davidfowl approved these changes

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@captainsafia captainsafia Awaiting requested review from captainsafia

Assignees
No one assigned
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunandabalu @davidfowl @eerhardt @danmoseley
0