8000 Update using-latest-daily.md by danmoseley · Pull Request #7692 · dotnet/aspire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update using-latest-daily.md #7692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Update using-latest-daily.md #7692

merged 3 commits into from
Feb 19, 2025

Conversation

danmoseley
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings February 19, 2025 22:13
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

docs/using-latest-daily.md:49

  • There is an inconsistency in the command examples: the first example omits the 'dotnet new install' command and '--force' flag, while the second example includes them. Consider unifying both examples to improve clarity.
> Release branches are a little different. For example, for the latest build from `release/X.X` branch change the above to be `Aspire.ProjectTemplates::X.X.*-*`. For example, if you want to use the latest build from the `release/9.2` branch, change the above to be `dotnet new install Aspire.ProjectTemplates::9.2.*-* --force`

@@ -42,7 +45,7 @@ dotnet new install Aspire.ProjectTemplates::*-* --force
```

> [!TIP]
> If you want to use the latest build from the `release/9.0-rc1` branch, change the above to be `dotnet new install Aspire.ProjectTemplates::9.0.0-rc.1.* --force`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wtgodbe was this correct? there's a period between rc and 1 that wasn't in 9.0-rc1. I guess , whatever

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying there was a time when we were versioning packages "9.0.0-rc-{suffix}"? That doesn't sound right

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm saying the deleted line contains both "rc1" and "rc.1"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's fine. The branch would be named rc1, and the packages would be versioned rc.1. That's typical.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fine but it means we need to document the feed for each rc, since they can't follow the obvious pattern.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm confused - it looks to me like the language here describes how to specify the package version, not the feed. Each release/9* branch will publish to the same feed (dotnet9) up until the point that we stabilize - the same is true for RC branches

@danmoseley danmoseley merged commit 5126607 into main Feb 19, 2025
67 of 68 checks passed
@danmoseley danmoseley deleted the danmoseley-patch-1 branch February 19, 2025 22:53
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0