8000 Don't skip event hub health checks by sebastienros · Pull Request #7670 · dotnet/aspire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Don't skip event hub health checks #7670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2025
Merged

Don't skip event hub health checks #7670

merged 2 commits into from
Feb 19, 2025

Conversation

sebastienros
Copy link
Member
@sebastienros sebastienros commented Feb 19, 2025 •
edited
Loading

Description

Event Hub singleton health check would be skipped if health checks were not supported. We don't want to not support them so removing this skipping logic.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot AI review requested due to automatic review settings February 19, 2025 00:48
Copilot
Copilot AI reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

tests/Aspire.Azure.Messaging.EventHubs.Tests/ConformanceTestsBase.cs:71

  • Ensure that the behavior of running health checks regardless of support is covered by tests.
public void HealthChecksClientsAreReused()

eerhardt
eerhardt approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member
@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eerhardt eerhardt enabled auto-merge (squash) February 19, 2025 02:52
@eerhardt eerhardt merged commit 8b6b83c into main Feb 19, 2025
70 checks passed
@eerhardt eerhardt deleted the sebros/noskiphc branch February 19, 2025 03:07
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastienros @eerhardt
0