8000 Mitchdenny/wait-behavior-follow-up by mitchdenny · Pull Request #7668 · dotnet/aspire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Mitchdenny/wait-behavior-follow-up #7668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 19, 2025
Merged

Mitchdenny/wait-behavior-follow-up #7668

merged 3 commits into from
Feb 19, 2025

Conversation

mitchdenny
Copy link
Member

Description

Follow up to #7650. Renames WaitBehavior enumeration values and adopts Davids ShouldYield inner method.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot AI review requested due to automatic review settings February 19, 2025 00:27
@mitchdenny mitchdenny self-assigned this Feb 19, 2025
@mitchdenny mitchdenny added the area-app-testing Issues pertaining to the APIs in Aspire.Hosting.Testing label Feb 19, 2025
@mitchdenny mitchdenny added this to the 9.1 milestone Feb 19, 2025
Copilot
Copilot AI reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Copilot
Copilot AI reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Aspire.Hosting/ResourceBuilderExtensions.cs:741

  • Renamed WaitBehavior enumeration values to StopOnResourceUnavailable and WaitOnResourceUnavailable.
WaitFor(messaging, WaitBehavior.StopOnResourceUnavailable);

eerhardt
eerhardt approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member
@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just 2 comments on comments

@mitchdenny mitchdenny merged commit d8ab7d0 into main Feb 19, 2025
70 checks passed
@mitchdenny mitchdenny deleted the mitchdenny/wait-behavior-follow-up branch February 19, 2025 01:18
@mitchdenny
Copy link
Member Author

/backport to release/9.1

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13403420214

@github-actions github-actions bot mentioned this pull request Feb 19, 2025
Merged
@afscrome afscrome mentioned this pull request Feb 19, 2025
Merged
18 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@eerhardt eerhardt eerhardt approved these changes

@davidfowl davidfowl Awaiting requested review from davidfowl

Assignees

@mitchdenny mitchdenny

Labels
area-app-testing Issues pertaining to the APIs in Aspire.Hosting.Testing
Projects
None yet
Milestone
9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchdenny @eerhardt
0