Fix console logs menu buttons not updated with resource #7639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
tests/Aspire.Dashboard.Components.Tests/Pages/ConsoleLogsTests.cs:253
- [nitpick] The variable name 'testResource' is ambiguous. It should be renamed to 'initialTestResource' and 'updatedTestResource' for clarity.
var testResource = ModelTestHelpers.CreateResource(
tests/Shared/DashboardModel/ModelTestHelpers.cs:42
- The 'commands' parameter should be checked for null before assigning to 'Commands'. Use 'commands ?? ImmutableArray.Empty' to avoid potential NullReferenceException.
Commands = commands ?? [],
davidfowl
approved these changes
Feb 17, 2025
8000
|
baxkport plz |
|
/backport to release/9.1 |
|
Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13362019979 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A recent regression caused the console logs page to not update the menu buttons when the resource changes. This means resource commands didn't change with the resource.
Fix + add test
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):