8000 Fix sorting by resource start time by JamesNK · Pull Request #6728 · dotnet/aspire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix sorting by resource start time #6728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix sorting by resource start time #6728

merged 1 commit into from
Nov 20, 2024

Conversation

JamesNK
Copy link
Member
@JamesNK JamesNK commented Nov 19, 2024 •
edited by dotnet-policy-service bot
Loading

Description

The displayed value changed to StartTimeStamp, but the tooltip and sorting still used CreationTimeStamp.

Fixes #6687

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@davidfowl
Copy link
Member

No tests?

@JamesNK
Copy link
Member Author
JamesNK commented Nov 19, 2024

No, the sorting is done by fluent UI grid control. I don’t think it’s worth it in this case

@JamesNK
Copy link
Member Author
JamesNK commented Nov 20, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK JamesNK merged commit fce0b51 into main Nov 20, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/resource-start-sort branch November 20, 2024 23:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@drewnoakes drewnoakes Awaiting requested review from drewnoakes

@adamint adamint Awaiting requested review from adamint

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@eerhardt eerhardt Awaiting requested review from eerhardt

Assignees
No one assigned
Labels
area-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WebToolsE2E][Aspire] Selecting sort [ascending/descending] for 'Start Time' column in Aspire 9.1 dashboard, the arrangement of time is incorrect.
2 participants
@JamesNK @davidfowl
0