8000 Fix source column displaying executable args by JamesNK · Pull Request #6619 · dotnet/aspire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix source column displaying executable args #6619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

JamesNK
Copy link
Member
@JamesNK JamesNK commented Nov 6, 2024

Description

Fixes #6585

After:

image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK merged commit 3e8d46c into main Nov 7, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/source-column-executable-fixes branch November 7, 2024 00:02
@JamesNK
Copy link
Member Author
JamesNK commented Nov 7, 2024

/backport to release/9.0

Copy link
Contributor
github-actions bot commented Nov 7, 2024

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11713945866

Copy link
Contributor
github-actions bot commented Nov 7, 2024

@JamesNK backporting to release/9.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix source column displaying executable args
Using index info to reconstruct a base tree...
M	src/Aspire.Dashboard/Components/ResourcesGridColumns/SourceColumnDisplay.razor
Falling back to patching base and 3-way merge...
Auto-merging src/Aspire.Dashboard/Components/ResourcesGridColumns/SourceColumnDisplay.razor
CONFLICT (content): Merge conflict in src/Aspire.Dashboard/Components/ResourcesGridColumns/SourceColumnDisplay.razor
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix source column displaying executable args
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Copy link
Contributor
github-actions bot commented Nov 7, 2024

@JamesNK an error occurred while backporting to release/9.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
6C63
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to command line args display in the dashboard
2 participants
0