[release/9.0] Don't display telemetry actions when no telemetry #6571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
approved these changes
Nov 1, 2024
joperezr
requested changes
Nov 1, 2024
|
Re-opening this as we want to take it as part of a special build for ACA. This will not be part of the 9.0.0 release, and instead will be branded as 9.0.1-preview |
joperezr
approved these changes
Nov 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6568 to release/9.0
/cc @JamesNK
Customer Impact
Aspire 9 added telemetry quick links to the resource action menu. If there is no telemetry for a resource then the links are disabled. If there is telemetry they are enabled.
The match between the Aspire resource and the telemetry resource is based on the name. If the names are different then disabled links are shown. This is undesirable because the Aspire resource does have telemetry, just with a slightly different name. The user could be confused.
The fix is to not show disabled telemetry links. If the names don't match then there is no down side, and if the names do match then the links are available.
Testing
Manual
Risk
Low
Regression?
Kind of. Aspire 9 adds "incorrect" telemetry links in dashboard usage when Aspire and telemetry resource names don't match.
Microsoft Reviewers: Open in CodeFlow