8000
Allow DAPR apps without a http endpoint to function correctly by oising · Pull Request #6362 · dotnet/aspire · GitHub
More Web Proxy on the site http://driver.im/
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DAPR hosting WithDaprSideCar() expects the application to always expose a http endpoint. In the DAPR world, this is not the expectation. Only apps that expect to work with input bindings or subscribe to a pubsub topic (i.e. receive messages or events) are expected to have an http endpoint.
It seems a regression was introduced where an endpoint validation was previously a null check, and now it requires an IsAllocated boolean test. I also simplified the tests into patterns and unified the three checks across all three if statements checking appPort, appChannelAddress and appProtocol respectively.
I added a third "service C" to the playground app to validate that a service without an endpoint is successfully launched.
Unit tests (to come?) -- but they look pretty arcane. Might need some pointers.
Spoke to the team and since we have little dapr test coverage at the moment I will merge this into main so that we can do more testing. Worst case is that we can back port to 9.0.1 if it doesn't make this release.
Spoke to the team and since we have little dapr test coverage at the moment I will merge this into main so that we can do more testing. Worst case is that we can back port to 9.0.1 if it doesn't make this release.
I did add extend the playground app for it to verify, but yeah, I wish I could help more. Ultimately though, without this fix, the dapr support is very limited (without very disruptive workarounds)
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-app-modelIssues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplicationcommunity-contributionIndicates that the PR has been added by a community member
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The DAPR hosting
WithDaprSideCar()expects the application to always expose a http endpoint. In the DAPR world, this is not the expectation. Only apps that expect to work with input bindings or subscribe to a pubsub topic (i.e. receive messages or events) are expected to have an http endpoint.It seems a regression was introduced where an endpoint validation was previously a null check, and now it requires an
IsAllocatedboolean test. I also simplified the tests into patterns and unified the three checks across all threeifstatements checking appPort, appChannelAddress and appProtocol respectively.I added a third "service C" to the playground app to validate that a service without an endpoint is successfully launched.
Unit tests (to come?) -- but they look pretty arcane. Might need some pointers.
Fixes #3687
Checklist
<remarks />and<code />elements on your triple slash comments?