8000 Reject spans that create a circular loop by JamesNK · Pull Request #6262 · dotnet/aspire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Reject spans that create a circular loop #6262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 21, 2024
Merged

Reject spans that create a circular loop #6262

merged 6 commits into from
Oct 21, 2024

Conversation

JamesNK
Copy link
Member
@JamesNK JamesNK commented Oct 12, 2024 •
edited
Loading

Description

Spans have a parent. A span is not allowed reference itself or one of its anscetors as a parent.

Data sent to the dashboard could contain an invalid circular reference. Rendering the bad data in the UI could cause errors. This PR adds validation logic when spans are received to reject the bad data.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK requested review from drewnoakes and adamint October 12, 2024 05:30
mitchdenny
mitchdenny reviewed Oct 15, 2024
View reviewed changes
drewnoakes
drewnoakes reviewed Oct 16, 2024
View reviewed changes
@JamesNK JamesNK force-pushed the jamesnk/span-loop-validation branch from 6556856 to 63583de Compare October 16, 2024 08:32
@JamesNK JamesNK added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 16, 2024
@JamesNK
Copy link
Member Author
JamesNK commented Oct 16, 2024

I think the changes are too broad to add to 9.0. Can be merged for vnext.

@JamesNK JamesNK force-pushed the jamesnk/span-loop-validation branch from 63583de to dd1ec4d Compare October 21, 2024 01:23
@JamesNK JamesNK removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 21, 2024
@JamesNK
Copy link
Member Author
JamesNK commented Oct 21, 2024

PR feedback addressed.

@JamesNK JamesNK merged commit 5deda3d into main Oct 21, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/span-loop-validation branch October 21, 2024 13:16
@JamesNK JamesNK mentioned this pull request Oct 23, 2024
Merged
16 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mitchdenny mitchdenny 5D95 mitchdenny left review comments

@drewnoakes drewnoakes drewnoakes approved these changes

@adamint adamint Awaiting requested review from adamint

Assignees
No one assigned
Labels
area-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesNK @drewnoakes @mitchdenny
0