8000 Change details view orientation and hide columns on resize by JamesNK · Pull Request #5604 · dotnet/aspire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change details view orientation and hide columns on resize #5604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2024
Merged

Change details view orientation and hide columns on resize #5604

merged 4 commits into from
Sep 9, 2024

Conversation

JamesNK
Copy link
Member
@JamesNK JamesNK commented Sep 9, 2024 •
edited
Loading

Description

New in this PR:

  • Grids switch to mobile view based on details view size.
  • Details view now defaults to vertical orientation.
  • GridColumnManager is now a component. It's easier to update page state and have dispose automatically called when a component.
  • Resource grid mobile view now hides type and shows state.

Fixes #5435

Demo:
details-view-resize

Tip

There are a lot of whitespace changes. Best reviewed with whitespace disabled.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK changed the title Update Change details view orientation and hide columns on resize Sep 9, 2024
adamint
adamint approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member
@adamint adamint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled down as well and looks good to me.

@adamint
Copy link
Member
adamint commented Sep 9, 2024

/azp run

@adamint adamint enabled auto-merge (squash) September 9, 2024 15:55
@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@adamint adamint merged commit c3a4754 into main Sep 9, 2024
11 checks passed
@adamint adamint deleted the jamesnk/details-display branch September 9, 2024 16:46
@build-analysis build-analysis bot mentioned this pull request Sep 11, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamint adamint adamint approved these changes

@drewnoakes drewnoakes Awaiting requested review from drewnoakes

@leslierichardson95 leslierichardson95 Awaiting requested review from leslierichardson95

@tlmii tlmii Awaiting requested review from tlmii

@kvenkatrajan kvenkatrajan Awaiting requested review from kvenkatrajan

Assignees
No one assigned
Labels
area-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide columns when space is limited because of the details view
2 participants
@JamesNK @adamint
0