-
Notifications
You must be signed in to change notification settings - Fork 647
Updating NuGet and Docker versions to latest #5405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azp run dotnet.aspire |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming CI is green. This LGTM
Extract phpmyadmin image and tag to follow the pattern used everywhere else.
Related - #5406 |
@@ -7,7 +7,7 @@ internal static class RedisContainerImageTags | |||
{ | |||
public const string Registry = "docker.io"; | |||
public const string Image = "library/redis"; | |||
public const string Tag = "7.2"; | |||
public const string Tag = "7.4"; | |||
public const string RedisCommanderRegistry = "docker.io"; | |||
public const string RedisCommanderImage = "rediscommander/redis-commander"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems there are more recent drops of the Redis Commander image at https://github.com/joeferner/redis-commander/pkgs/container/redis-commander which is from the actual author. Perhaps we should consider changing to that registry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, but I'd probably just separate that change so that it stays in main (9.0) only to get more bake time as this PR is going to get backported to 8.2.
For future reference, this is the script I used to find latest tags of each image: #!/bin/bash
# Check if repository argument is provided
if [ -z "$1" ]; then
echo "Usage: $0 <repository>"
exit 1
fi
REPO=$1
echo "Repository: $REPO"
echo "Fetching tags..."
# Fetch all tags
TAGS=$(skopeo list-tags docker://$REPO | jq -r '.Tags[]')
# Sort tags numerically using version sort (sort -V)
echo "$TAGS" | sort -V |
/azp run dotnet.aspire |
Azure Pipelines successfully started running 1 pipeline(s). |
/backport to release/8.2 |
Started backporting to release/8.2: https://github.com/dotnet/aspire/actions/runs/10540170837 |
We also need to update triple slash comments that callout the image tag numbers, for example this was bumped to
|
Good catch. I wonder if there is a better way than duplicating those versions in the XML doc comments. Is it possible for |
Description
Updating our NuGet package dependencies as well as our Docker container image tags to latest. Note: build will fail until we push all the required packages and images to the internal mirrors.
Checklist
<remarks />
and<code />
elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow