8000 Updating NuGet and Docker versions to latest by joperezr · Pull Request #5405 · dotnet/aspire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Updating NuGet and Docker versions to latest #5405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 24, 2024

Conversation

joperezr
Copy link
Member
@joperezr joperezr commented Aug 23, 2024

Description

Updating our NuGet package dependencies as well as our Docker container image tags to latest. Note: build will fail until we push all the required packages and images to the internal mirrors.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
        < 8000 /li>
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-integrations Issues pertaining to Aspire Integrations packages label Aug 23, 2024
@joperezr
Copy link
Member Author

/azp run dotnet.aspire

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member
@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI is green. This LGTM

eerhardt and others added 2 commits August 23, 2024 16:22
@radical
Copy link
Member
radical commented Aug 24, 2024

Related - #5406

@@ -7,7 +7,7 @@ internal static class RedisContainerImageTags
{
public const string Registry = "docker.io";
public const string Image = "library/redis";
public const string Tag = "7.2";
public const string Tag = "7.4";
public const string RedisCommanderRegistry = "docker.io";
public const string RedisCommanderImage = "rediscommander/redis-commander";
Copy link
Member
@DamianEdwards DamianEdwards Aug 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems there are more recent drops of the Redis Commander image at https://github.com/joeferner/redis-commander/pkgs/container/redis-commander which is from the actual author. Perhaps we should consider changing to that registry?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, but I'd probably just separate that change so that it stays in main (9.0) only to get more bake time as this PR is going to get backported to 8.2.

@joperezr
Copy link
Member Author

For future reference, this is the script I used to find latest tags of each image:

#!/bin/bash

# Check if repository argument is provided
if [ -z "$1" ]; then
    echo "Usage: $0 <repository>"
    exit 1
fi

REPO=$1

echo "Repository: $REPO"
echo "Fetching tags..."

# Fetch all tags
TAGS=$(skopeo list-tags docker://$REPO | jq -r '.Tags[]')

# Sort tags numerically using version sort (sort -V)
echo "$TAGS" | sort -V

@joperezr
Copy link
Member Author

/azp run dotnet.aspire

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@joperezr joperezr merged commit 32ba296 into dotnet:main Aug 24, 2024
11 checks passed
@joperezr
Copy link
Member Author

/backport to release/8.2

Copy link
Contributor

Started backporting to release/8.2: https://github.com/dotnet/aspire/actions/runs/10540170837

@IEvangelist
Copy link
Member
IEvangelist commented Aug 26, 2024

We also need to update triple slash comments that callout the image tag numbers, for example this was bumped to 8.15 but in the release/8.2 branch the remarks still read as 8.14 - I haven't looked everywhere, but I assume that same is true for most other places:

/// <remarks>
/// The default image is "elasticsearch" and the tag is "8.14.0".
/// </remarks>

/cc @joperezr @eerhardt

@eerhardt
Copy link
Member

We also need to update triple slash comments that callout the image tag numbers, for example this was bumped to 8.15 but in the release/8.2 branch the remarks still read as 8.14 - I haven't looked everywhere, but I assume that same is true for most other places:

/// <remarks>
/// The default image is "elasticsearch" and the tag is "8.14.0".
/// </remarks>

/cc @joperezr @eerhardt

Good catch. I wonder if there is a better way than duplicating those versions in the XML doc comments. Is it possible for const strings to be substituted in XML docs?

@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0