8000 Fix JUnit message / type fields. by AnthonyBarbier · Pull Request #399 · dorny/test-reporter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix JUnit message / type fields. #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions __tests__/__outputs__/swift-xunit.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ AcmeLibTests.AcmeLibTests
✅ test_always_pass
✅ test_always_skip
❌ test_always_fail
failed
```
4 changes: 2 additions & 2 deletions __tests__/__snapshots__/java-junit.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ at java.lang.Thread.run(Thread.java:748)

",
"line": 29,
"message": undefined,
"message": "java.lang.AssertionError: expected [1.2.1] but found [1.2.0]",
"path": "pulsar-common/src/test/java/org/apache/pulsar/AddMissingPatchVersionTest.java",
},
"name": "testVersionStrings",
Expand Down Expand Up @@ -100,7 +100,7 @@ at java.lang.Thread.run(Thread.java:748)

",
"line": 29,
"message": undefined,
"message": "java.lang.AssertionError: expected [1.2.1] but found [1.2.0]",
"path": "pulsar-common/src/test/java/org/apache/pulsar/AddMissingPatchVersionTest.java",
},
"name": "testVersionStrings",
Expand Down
2 changes: 1 addition & 1 deletion __tests__/__snapshots__/swift-xunit.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ TestRunResult {
"error": {
"details": undefined,
"line": undefined,
"message": undefined,
"message": "failed",
"path": undefined,
},
"name": "test_always_fail",
Expand Down
11 changes: 9 additions & 2 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion src/parsers/java-junit/java-junit-parser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,18 @@ export class JavaJunitParser implements TestParser {
}
}

let message
if (typeof failure === 'object') {
message = failure.$.message
if (failure.$?.type) {
message = failure.$.type + ': ' + message
}
}
return {
path: filePath,
line,
details,
message: typeof failure === 'object' ? failure.message : undefined
message
}
}

Expand Down
6 changes: 4 additions & 2 deletions src/parsers/java-junit/java-junit-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ export interface TestCase {

export interface Failure {
_: string
type: string
message: string
$: {
type?: string
message: string
}
}
0