Minor updates for the 3.1.0 release #3571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic attempted to simplify the process by retrieving the first element of the document root. After the first page this would be incorrect since the previous body element exists in the frame tree until the after the current body completed rendering. fixes #3570
This change prevents logic or rendering errors in scenarios where a CSS calc function utilizes a non-existent variable as one of the operands. ref #3530
Prior to this change a pseudo-element would not be generated if it's only content was a custom property reference. This is because the frame is generated before styles are applied and the custom property reference is unable to resolve. The lack of content in a pseudo-element precludes frame generation.
Even if a frame is generated, it is not rendered to the page if it has no content. This change modifies the content check to exclude only if there is no content (null) rather than empty ("").
fixes #2775 and #3573
This was
linked to
issues
Jan 12, 2025
Closed
Though not valid per the spec to include whitespace in the non-data portion of the data-URI, browser do perform a similar operation. The whitespace removal is done after initial failure in order to minimize impact on documents with a correcty formatted data-URIs. fixes #1386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.