8000 Refactor Options class set and get methods, and add comprehensive tes… by MuneebStack · Pull Request #3471 · dompdf/dompdf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor Options class set and get methods, and add comprehensive tes… #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor Options class set and get methods, and add comprehensive tes… #3471

wants to merge 3 commits into from

Conversation

MuneebStack
Copy link

Refactor Options class set and get methods for improved readability and maintainability

  • Updated the set and get methods in the Options class to enhance readability and reduce time complexity by eliminating long lists of if-else statements inside the loop. The methods now dynamically match attribute names using camelCase or underscore naming conventions.
  • Added test cases to cover both camelCase and underscore naming conventions for setter and getter methods.
  • Expanded existing test cases to include previously missing keys.

@bsweeney bsweeney added this to the 3.0.1 milestone Jun 1, 2024
@bsweeney bsweeney modified the milestones: 3.0.1, 3.0.2 Dec 2, 2024
@MuneebStack
Copy link
Author

@bsweeney Please merge this PR.
Thank you !

bsweeney
bsweeney requested changes May 25, 2025
View reviewed changes
Copy link
Member
@bsweeney bsweeney left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to resolve the conflict on this PR?

@MuneebStack
Copy link
Author

Are you able to resolve the conflict on this PR?

Ok @bsweeney I will update it today. Sorry I missed the message.

@MuneebStack MuneebStack force-pushed the feature/options-refactor branch from d6311fb to 151d3d6 Compare June 14, 2025 07:00
@MuneebStack
Copy link
Author

@bsweeney Resolved the conflicts. Please review it.

@MuneebStack MuneebStack requested a review from bsweeney June 14, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsweeney bsweeney Awaiting requested review from bsweeney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@MuneebStack @bsweeney
0