8000 Add type declaration to paper-orientation parameters by Mellthas · Pull Request #3060 · dompdf/dompdf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add type declaration to paper-orientation parameters #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2022
Merged

Add type declaration to paper-orientation parameters #3060

merged 1 commit into from
Nov 14, 2022

Conversation

Mellthas
Copy link
Member
@Mellthas Mellthas commented Nov 7, 2022

Addresses #3055

@bsweeney
Copy link
Member
bsweeney commented Nov 8, 2022

Too bad we're not yet at PHP 8.0 as the minimum so we could use a union type on the paper argument.

@bsweeney bsweeney added this to the 2.0.2 milestone Nov 8, 2022
@Mellthas Mellthas force-pushed the orientation-type-decl branch from 28c4798 to e0865d9 Compare November 14, 2022 11:54
@Mellthas Mellthas merged commit 9c12634 into master Nov 14, 2022
@Mellthas Mellthas deleted the orientation-type-decl branch November 14, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsweeney bsweeney bsweeney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Mellthas @bsweeney
0