Several selector fixes #3059
Merged
Several selector fixes #3059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
Test case for the ID-selector fixHTML<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<style>
@page {
size: 400pt 300pt;
margin: 50pt;
}
h1 {
margin: 0 0 10pt 0;
font-size: 1.5rem;
}
div + h1 {
margin-top: 10pt;
}
#test {
outline: medium solid red;
}
.test {
outline: medium solid red;
}
</style>
</head>
<body>
<h1>ID</h1>
<div id="test">test</div>
<div id="test with space">test with space</div>
<h1>Class</h1>
<div class="test">test</div>
<div class="test with space">test with space</div>
</body>
</html> |
Test case for the attribute-selector fixesRed background and yellow font should not be applied. HTML<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<style>
@page {
size: 400pt 300pt;
margin: 50pt;
}
html {
font-size: 2em;
}
[title~=test] {
text-decoration: underline;
}
[title~="I'm"] {
font-weight: bold;
}
[title~="a test"] {
background-color: red;
}
[title~=""] {
color: yellow;
}
[title^="Ano"] {
text-decoration: underline;
}
[title$="ther"] {
font-weight: bold;
}
[title^=""] {
color: yellow;
}
[title$=""] {
background-color: red;
}
[title*="tain"] {
font-weight: bold;
text-decoration: underline;
}
[title*=""] {
color: yellow;
background-color: red;
}
</style>
</head>
<body style="background-color: transparent;">
<div title="I'm a test">Space-separated</div>
<div title="Another">Starts-with, ends-with</div>
<div title="contains">Contains</div>
</body>
</html>attribute-substring-before.pdf |
bsweeney
approved these changes
Nov 14, 2022
The match must be exact, the ID attribute is not a space-separated list of tokens like the class attribute.
1a39c8a to
7cc036d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nth-childwhen combined with other conditionsApplies on top of #3057
Fixes #2222
Partially addresses #3056