8000 Fix start command panic when ran with no args by dboslee · Pull Request #199 · dominikbraun/timetrace · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix start command panic when ran with no args #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2021
Merged

Fix start command panic when ran with no args #199

merged 1 commit into from
Oct 22, 2021

Conversation

dboslee
Copy link
Contributor
@dboslee dboslee commented Oct 22, 2021

This sets the minimum number of arguments for the start
command to 1.

Fixes #198

@dboslee
Fix start command panic when ran with no args
71ebb46 
This sets the minimum number of arguments for the start
command to 1.
@dominikbraun dominikbraun self-requested a review October 22, 2021 08:57
dominikbraun
dominikbraun approved these changes Oct 22, 2021
View reviewed changes
Copy link
Owner
@dominikbraun dominikbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this! 👍

@dominikbraun dominikbraun merged commit 1134a1f into dominikbraun:main Oct 22, 2021
@dominikbraun
Copy link
Owner

This PR has been released as timetrace v0.14.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikbraun dominikbraun dominikbraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime Error when using timetrace start
2 participants
@dboslee @dominikbraun
0