8000 #151 create record validation if it is happened in future by alksmt · Pull Request #152 · dominikbraun/timetrace · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

#151 create record validation if it is happened in future #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2021
Merged

#151 create record validation if it is happened in future #152

merged 2 commits into from
Jul 5, 2021

Conversation

alksmt
Copy link
Contributor
@alksmt alksmt commented Jun 30, 2021

PR for #151

Added validation to create command to check if provided record happend after current timestamp.

jwnpoh
jwnpoh reviewed Jul 3, 2021
View reviewed changes
@dominikbraun dominikbraun added this to the timetrace v0.11.x milestone Jul 4, 2021
@dominikbraun dominikbraun linked an issue Jul 4, 2021 that may be closed by this pull request
Check if a new record created happend before current time. #151
Closed
dominikbraun
dominikbraun approved these changes Jul 5, 2021
View reviewed changes
Copy link
Owner
@dominikbraun dominikbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well, thanks for fixing this! Your fixes will be included in the next patch release today.

@dominikbraun dominikbraun merged commit 887fe7b into dominikbraun:main Jul 5, 2021
@dominikbraun
Copy link
Owner

This PR is included in timetrace v0.11.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwnpoh jwnpoh jwnpoh left review comments

@dominikbraun dominikbraun dominikbraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if a new record created happend before current time.
3 participants
@alksmt @dominikbraun @jwnpoh
0