8000 Added a new constant for string columns created during schema import. by timsehn · Pull Request #9272 · dolthub/dolt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added a new constant for string columns created during schema import. #9272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send 8000 you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

Added a new constant for string columns created during schema import. #9272

merged 1 commit into from
May 29, 2025

Conversation

timsehn
Copy link
Contributor
@timsehn timsehn commented May 29, 2025

Length is 200 instead of 1023.

Fixes: #8972

macneale4
macneale4 approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor
@macneale4 macneale4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@coffeegoddd
Copy link
Contributor

@timsehn DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5548e0f ok 5937457
version total_tests
5548e0f 5937457
correctness_percentage
100.0

@timsehn timsehn merged commit 5b15cff into main May 29, 2025
34 of 37 checks passed
@BrewTestBot BrewTestBot mentioned this pull request May 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macneale4 macneale4 macneale4 approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

varchar types inferred on schema import are set to size 1023. 18 occurrences overflow row size limit
3 participants
@timsehn @coffeegoddd @macneale4
0