8000 Adding `dolt_update_column_tag()` stored procedure by fulghum · Pull Request #9219 · dolthub/dolt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adding dolt_update_column_tag() stored procedure #9219

New issue

Have a question about this project? Sign up for a free Gi 8000 tHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

Adding dolt_update_column_tag() stored procedure #9219

merged 1 commit into from
May 15, 2025

Conversation

fulghum
Copy link
Contributor
@fulghum fulghum commented May 14, 2025 •
edited
Loading

Adds the dolt_update_column_tag() stored procedure to update a column's tag. This is an advanced operation that most users will not need to use. This blog explains more about column tags and column tag conflicts.

Example usage:

CALL dolt_update_column_tag('myTable', 'col1', 4321);

Follow ups:

  • Add docs for the new dolt_schema_update_tag() stored procedure
  • The dolt schema update-tag CLI command should be updated to use this stored procedure.

@fulghum fulghum requested a review from zachmu May 15, 2025 00:01
@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
70d2f51 ok 5937457
version total_tests
70d2f51 5937457
correctness_percentage
100.0

@macneale4 macneale4 self-requested a review May 15, 2025 19:39
macneale4
macneale4 approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor
@macneale4 macneale4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I would prefer enginetests. I leave it to you to decide on that. Feel free to ship without another review regardless.

@fulghum fulghum force-pushed the fulghum/dolt_update_column_tag branch from 70d2f51 to 9277d24 Compare May 15, 2025 21:18
@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9277d24 ok 5937457
version total_tests
9277d24 5937457
correctness_percentage
100.0

@fulghum fulghum merged commit f0b147e into main May 15, 2025
21 checks passed
@fulghum fulghum deleted the fulghum/dolt_update_column_tag branch May 15, 2025 22:22
@BrewTestBot BrewTestBot mentioned this pull request May 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macneale4 macneale4 macneale4 approved these changes

@zachmu zachmu Awaiting requested review from zachmu

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fulghum @coffeegoddd @macneale4
0