8000 go: statspro: Make it possible for callers of StatsController.Stop() to block on the worker thread shutdown. by reltuk · Pull Request #9192 · dolthub/dolt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

go: statspro: Make it possible for callers of StatsController.Stop() to block on the worker thread shutdown. #9192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

go: statspro: Make it possible for callers of StatsController.Stop() to block on the worker thread shutdown. #9192

merged 2 commits into from
May 7, 2025

Conversation

reltuk
Copy link
Contributor
@reltuk reltuk commented May 7, 2025

Add pre-finalize blocking on the worker thread shutdown to dolt_gc safepoint controllers.

Add blocking on the worker thread shutdown to dolt_stats_stop(), so that a caller knows that stats have actually stopped by the time it returns.

@reltuk
go: statspro: Make it possible for callers of StatsController.Stop() …
fa7e202 
…to block on the worker thread shutdown.

Add pre-finalize blocking on the worker thread shutdown to dolt_gc safepoint controllers.

Add blocking on the worker thread shutdown to dolt_stats_stop(), so that a
caller knows that stats have actually stopped by the time it returns.
@reltuk reltuk requested a review from max-hoffman May 7, 2025 20:09
max-hoffman
max-hoffman approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor
@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this makes the behavior more predictable. My main worry is stats-GC deadlocks given the extra complexity.

@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
fa7e202 ok 5937457
version total_tests
fa7e202 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

< 8000 tr>
comparing_percentages
100.000000 to 100.000000
version result total
6f793e3 ok 5937457
version total_tests
6f793e3 5937457
correctness_percentage
100.0

@reltuk reltuk merged commit 1c50976 into main May 7, 2025
21 of 22 checks passed
@BrewTestBot BrewTestBot mentioned this pull request May 8, 2025
Merged
@tbantle22 tbantle22 deleted the aaron/gc-stats-block-on-runWorker-done-before-finalizing-gc branch May 28, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reltuk @coffeegoddd @max-hoffman
0