8000 Remove temporary SQLite file on teardown by morozov · Pull Request #3745 · doctrine/dbal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove temporary SQLite file on teardown #3745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2019
Merged

Remove temporary SQLite file on teardown #3745

merged 1 commit into from
Nov 25, 2019

Conversation

morozov
Copy link
Member
@morozov morozov commented Nov 24, 2019
Q A
Type bug
BC Break no

Summary

As of #3679, the test suite fails if run consequently in the same environment:

phpunit --repeat 2 --filter testTransactionNestingLevelIsResetOnReconnect tests/Doctrine/Tests/DBAL/Functional/ConnectionTest.php
PHPUnit 8.3.3 by Sebastian Bergmann and contributors.

.E                                                                                  2 / 2 (100%)

Time: 77 ms, Memory: 8.00 MB

There was 1 error:

1) Doctrine\Tests\DBAL\Functional\ConnectionTest::testTransactionNestingLevelIsResetOnReconnect
Exception: [Doctrine\DBAL\Exception\TableExistsException] An exception occurred while executing "CREATE TABLE test_nesting(test int not null)":

SQLSTATE[HY000]: General error: 1 table test_nesting already exists

@morozov morozov added this to the 2.10.1 milestone Nov 24, 2019
@Ocramius
Copy link
Member

@morozov this is for 2.10.1, but doesn't target 2.10.x?

@morozov
Copy link
Member Author
morozov commented Nov 24, 2019

I’ll backport it. Or did we already switch to merging up?

@Ocramius
Copy link
Member

Ges, the automated release tool already handles that

@greg0ire
Copy link
Member
greg0ire commented Nov 24, 2019 •
edited
Loading

Looking at the git graph, it does not seem 2.10 has been merged up into master recently. Is that expected?

@Ocramius
Copy link
Member

Since 2.10.0 wasn't released through automation, that's normal

@morozov morozov changed the base branch from master to 2.10 November 24, 2019 23:05
@morozov morozov force-pushed the sqlite-rm-temp-file branch from 2e84ca5 to adeaac5 Compare November 24, 2019 23:05
@morozov morozov merged commit 66d926b into doctrine:2.10 Nov 25, 2019
@morozov morozov deleted the sqlite-rm-temp-file branch November 25, 2019 00:04
@morozov morozov self-assigned this Nov 25, 2019
@morozov
Copy link
Member Author
morozov commented Nov 25, 2019

So, what should happen next?

@greg0ire
Copy link
Member

My guess:

  • the backport
  • at some point, an automated release
  • after that point always merge up?

But I don't really see a reason to not switch to merge up right now.

@morozov
Copy link
Member Author
morozov commented Nov 25, 2019 •
edited
Loading

@greg0ire I retargeted the PR against 2.10 before merging, so the changes are already there. Although, I don't see them merged upstream. Should it happen automatically or should we set something up to make it happen?

@greg0ire
Copy link
Member

Oh right, great, didn't notice… the implication of what @Ocramius said is that we need to do a release through automation for that to happen. @Ocramius , does that mean the merges up only ever happen when releasing, or that once we do this first release, the merge up will happen whenever something is merged on the stable branch? Asking because merging up infrequently will probably result to conflicts every time.

@morozov
Copy link
Member Author
morozov commented Nov 25, 2019

Asking because merging up infrequently will probably result to conflicts every time.

Also, bugs that exist in both the stable branch and master may prevent further development of the changes in master. I think, auto-merging stable to master as soon as they diverge is reasonable.

@doctrinebot doctrinebot mentioned this pull request Jan 4, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

@morozov morozov

Labels
Bug SQLite Test Suite
Projects
None yet
Milestone
2.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@morozov @Ocramius @greg0ire
0