8000 CS bump to 4.0, imports for global functions & constants by Majkl578 · Pull Request #3077 · doctrine/dbal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CS bump to 4.0, imports for global funct 8000 ions & constants #3077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2018
Merged

CS bump to 4.0, imports for global functions & constants #3077

merged 2 commits into from
Apr 1, 2018

Conversation

Majkl578
Copy link
Contributor
@Majkl578 Majkl578 commented Apr 1, 2018

CS is a simple bump (no change required since we use incremental diffs here).

Had to hack some sniffs to:

  • only add imports for functions/constants (and not classes as well)
  • to re-order only functions/constants (and not classes as well)

Would love to see this in 2.7, but not a dealbreaker.

@Majkl578 Majkl578 requested review from morozov and Ocramius April 1, 2018 01:40
@Majkl578 Majkl578 force-pushed the cs-4.0+fn-const-imports branch from 17b13bb to a89df6b Compare April 1, 2018 01:43
@Majkl578 Majkl578 force-pushed the cs-4.0+fn-const-imports branch from a89df6b to 9f3188a Compare April 1, 2018 01:46
Ocramius
Ocramius approved these changes Apr 1, 2018
View reviewed changes
Copy link
Member
@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an easy and big win. It won't make a huge difference in this test suite alome, but things like the DBAL types are used a gazillion times, and we may have some improvements there 👍

@Ocramius Ocramius self-assigned this Apr 1, 2018
@Ocramius Ocramius added this to the 2.7.0 milestone Apr 1, 2018
@Ocramius
Copy link
Member
Ocramius commented Apr 1, 2018

Checked scrutinizer issues: mostly raised by non-existence of exotic extensions (db2, sql anywhere, sqlsrv)

@Ocramius Ocramius merged commit f76bf5e into doctrine:master Apr 1, 2018
@Majkl578 Majkl578 deleted the cs-4.0+fn-const-imports branch April 2, 2018 00:31
@Bilge
Copy link
Contributor
Bilge commented Oct 30, 2019

But why was composer.lock readded?

@Ocramius
Copy link
Member

composer.lock is needed when testing with tools like phpcs, because they keep inadvertedly breaking BC.

We use composer install (with composer.lock) in some CI pipeline steps.

@morozov morozov removed their request for review October 23, 2020 16:58
@morozov morozov added Code Style and removed CS labels Feb 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Code Style Improvement
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Majkl578 @Ocramius @Bilge @morozov
0