8000 Enabled testFetchLongBlob() for PDO SQL Server driver by morozov · Pull Request #2952 · doctrine/dbal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enabled testFetchLongBlob() for PDO SQL Server driver #2952

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2017
Merged

Enabled testFetchLongBlob() for PDO SQL Server driver #2952

merged 1 commit into from
Dec 29, 2017

Conversation

morozov
Copy link
Member
@morozov morozov commented Dec 26, 2017

The test was disabled as part of #2546 because of microsoft/msphpsql/issues/270. It can be enabled since the issue is now fixed.

@morozov morozov added th 8000 e pdo_sqlsrv label Dec 27, 2017
@morozov morozov requested review from lcobucci and Majkl578 December 28, 2017 20:50
Majkl578
Majkl578 approved these changes Dec 28, 2017
View reviewed changes
Copy link
Contributor
@Majkl578 Majkl578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Would be cool to have CI for this driver, hopefully AppVeyor #2617 or we can try to set it up on Travis.

@Ocramius Ocramius self-assigned this Dec 29, 2017
@Ocramius Ocramius added this to the 2.7.0 milestone Dec 29, 2017
@Ocramius
Copy link
Member

🚢

@Ocramius Ocramius merged commit f3d41b8 into doctrine:master Dec 29, 2017
@morozov morozov deleted the microsoft/msphpsql/issues/270 branch December 29, 2017 18:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Majkl578 Majkl578 Majkl578 approved these changes

@lcobucci lcobucci Awaiting requested review from lcobucci

Assignees

@Ocramius Ocramius

Labels
Improvement pdo_sqlsrv Test Suite
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@morozov @Ocramius @Majkl578
0