8000 Travis: Test against lowest and dev dependencies by Majkl578 · Pull Request #2956 · doctrine/dbal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Travis: Test against lowest and dev dependencies #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2017
Merged

Travis: Test against lowest and dev dependencies #2956

merged 1 commit into from
Dec 29, 2017

Conversation

Majkl578
Copy link
Contributor
@Majkl578 Majkl578 commented Dec 29, 2017 •
edited
Loading

Extends build matrix with:

  • lowest dependencies
    • on lowest supported PHP version (7.1)
    • sqlite
    • always executed
  • dev dependencies

Currently fails, will need some investigation (the class exists, any idea anyone?):

1) Doctrine\Tests\DBAL\Tools\Console\RunSqlCommandTest::testMissingSqlArgument
Error: Class 'Symfony\Component\Console\Application' not found
/home/travis/build/Majkl578/doctrine-dbal/tests/Doctrine/Tests/DBAL/Tools/Console/RunSqlCommandTest.php:21

Found it: Symfony packages <2.0.5 didn't have autoload entry.

@Majkl578 Majkl578 removed the WIP label Dec 29, 2017
@Majkl578 Majkl578 requested review from morozov and lcobucci December 29, 2017 06:35
morozov
morozov reviewed Dec 29, 2017
View reviewed changes
.travis.yml
php: 7.2
env: DB=sqlite DEPENDENCIES=dev
install:
- composer config minimum-stability dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From doctrine/orm#6887 (comment):

Testing against dev dependencies is highly unreliable and non-deterministic.

Hopefully, someone will have enough time to triage the failures. BTW, where on Travis CI can I find the build results? I see doctrine/orm#6887 is already merged.

Copy link
Contributor Author
@Majkl578 Majkl578 Dec 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is (still) true, that's why it's not good for PRs. But it's good to spot bugs/incompatibilities early. It won't be noisy during PR/merge/push.

where on Travis CI can I find the build results?

It's listed with other builds, marked with "CRON" label:
https://travis-ci.org/doctrine/doctrine2/builds
https://travis-ci.org/doctrine/doctrine2/jobs/322719675
It's not enabled for DBAL (yet).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: First CRON build is there and passed: https://travis-ci.org/doctrine/dbal/builds

@Ocramius Ocramius self-assigned this Dec 29, 2017
@Ocramius Ocramius added this to the 8000 2.7.0 milestone Dec 29, 2017
@Ocramius
Copy link
Member

🚢

@Ocramius Ocramius merged commit 00381a6 into doctrine:master Dec 29, 2017
@Majkl578 Majkl578 deleted the ci-lowest-deps branch December 29, 2017 18:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morozov morozov morozov approved these changes

@lcobucci lcobucci Awaiting requested review from lcobucci

Assignees

@Ocramius Ocramius

Labels
CI Compatibility
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Majkl578 @Ocramius @morozov
0