Improve deprecation wording in Doctrine\DBAL\Schema\Column#setOptions()
#2935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/Doctrine/DBAL/Schema/Column.php
Outdated
| @@ -121,7 +121,7 @@ public function setOptions(array $options) | |||
| if ( ! method_exists($this, $method)) { | |||
| // next major: throw an exception | |||
| @trigger_error(sprintf( | |||
| 'The "%s" option is not supported,'. | |||
| 'The "%s" doctrine column option is not supported,'. | |||
| ' setting it is deprecated and will cause an error in 3.0', | |||
There was a problem hiding this comment.
my 2cts:
'The "%s" column option is not supported,'.
' setting it is deprecated and will cause an error in Doctrine 3.0',
People that are starting a new project will immediately know what this is about, but people upgrading doctrine might get a lot of these and should have a better clue regarding what this is about.
3732699 to
4256d17
Compare
Doctrine\DBAL\Schema\Column#setOptions()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People that are starting a new project will immediately know what this
is about, but people upgrading doctrine might get a lot of these and
should have a better clue regarding what this is about.