Refactoring tests #2927
Merged
Refactoring tests #2927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcobucci
suggested changes
Nov 27, 2017
| @@ -43,12 +43,12 @@ public function testReturnsSQLDeclaration() | |||
|
|
|||
| public function testJsonNullConvertsToPHPValue() | |||
| { | |||
| self::assertSame(array(), $this->type->convertToPHPValue(null, $this->platform)); | |||
| self::assertEmpty($this->type->convertToPHPValue(null, $this->platform)); | |||
There was a problem hiding this comment.
self::assertSame() must be kept here since Type#convertToPHPValue() has a mixed return and we must ensure that it's an array with no entry (not only something empty).
| } | ||
|
|
||
| public function testJsonEmptyStringConvertsToPHPValue() | ||
| { | ||
| self::assertSame(array(), $this->type->convertToPHPValue('', $this->platform)); | ||
| self::assertEmpty($this->type->convertToPHPValue('', $this->platform)); |
There was a problem hiding this comment.
self::assertSame() must be kept here since Type#convertToPHPValue() has a mixed return and we must ensure that it's an array with no entry (not only something empty).
|
@lcobucci I've changed your requested changes. |
lcobucci
approved these changes
Nov 28, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've refactored some tests with
assertFileExistsandassertFileNotExistsmethods.