8000 Correct `testListTableColumns` checked keys by mdwheele · Pull Request #2674 · doctrine/dbal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Correct testListTableColumns checked keys #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2017
Merged

Correct testListTableColumns checked keys #2674

merged 1 commit into from
Mar 11, 2017

Conversation

mdwheele
Copy link

While working on #2673, I noticed an apparent error in a test assertion and wanted to keep it separate from my other PR. In a repetitive assertion block for SchemaManagerFunctionalTestCase#testListTableColumns, a column named baz3 is being tested while a single assertion was testing baz2 from the block before.

@deeky666 deeky666 self-requested a review March 11, 2017 02:39
@deeky666 deeky666 self-assigned this Mar 11, 2017
@deeky666 deeky666 added this to the 2.6 milestone Mar 11, 2017
@deeky666 deeky666 merged commit 098d54c into doctrine:master Mar 11, 2017
@deeky666
Copy link
Member

@mdwheele thx! Good catch!

@Ocramius Ocramius changed the title Fix copy+paste error in testListTableColumns Correct testListTableColumns - copy-paste mistake Jul 22, 2017
@Ocramius Ocramius changed the title Correct testListTableColumns - copy-paste mistake Correct testListTableColumns checked keys Jul 22, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0