Revert PgSQL and MariaDB Travis-CI build matrix simplification #2660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes all sudo items (except hhvm which currently still requires sudo) reverting the other simpler matrix attempt
|
@photodude LGTM. One question though: Is there a reason we allow failures for PHP-nightly + PostgreSQL 9.5 / 9.6? Because it seems they are succeeding. |
|
@Ocramius so we might disallow failures here, right? If so, can you change this here @photodude ? We can merge afterwards. |
|
Nightly is set correctly now |
deeky666
approved these changes
Feb 22, 2017
|
@photodude thx! |
|
you are welcome, I hope to figure out the whole conditional addons in container at some point (if it is even possible) Maybe after trusty container is publicly released (still waiting for them to fix the mysql socket issues). |
|
I agree it's not the most elegant setup atm but at least it is working for now. Let's see what Travis offers us in the future ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all sudo items (except hhvm which currently still requires sudo)
reverting the other simpler matrix attempt at #2655