Fix drivers' exec() method to not execute queries via prepared statements
#2640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After going back and forth a few times, especially considering the test case changes, I'm going to merge this only into |
exec() method to not execute queries via prepared statements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the driver connection interface is not quite clear about this, the
exec()method is obviously intended for DML/DDL statements to be directly executed without preparing the statement beforehand. It is not possible to bind parameters here and it will only ever return affected rows.Now while nevertheless using prepared statements internally might not seem like such a big deal, there are some cons about this approach:
I also updated the testsuite where invalid
executeQuery()calls for DML/DDL statement where done.This bugfix is required for the SQL Server testsuite to succeed. It makes 16 errors succeed on this branch with
sqlsrv.I did not add any additonal tests because it is not possible to mock whether prepared statements are used or not and also all of the various test cases are already covered by functional tests.