Fix the reuse of a statement on sqlsrv with explicit bindValue() #2646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…Value() and bindParam()
8b8b55e to
d6a7079
Compare
|
@morozov would you be interested in joining the Doctrine core team? You did some very good quality additions to DBAL lately and we are still looking for support here :) |
|
@deeky666 it'd be my honor. Hopefully, my further contributions will not be that damaging :-). |
|
@morozov hehe no worries, we're all humans ;) Can you join on IRC #doctrine-dev (freenode network) and throw a private message at me? I will tell you more then. |
|
@morozov welcome to the team! Meanwhile, this is being merged :-) |
Ocramius
approved these changes
Feb 8, 2017
Ocramius
added a commit
that referenced
this pull request
Feb 8, 2017
…er-subsequent-calls' into 2.5 Backport #2646 to 2.5.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a value is bound with
bindValue()between statement executions, the value used on a subsequent execution is ignored. The same happens withbindParam(). See the tests.