Tear down active transactions in functional test cases
#2638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimhemsoe
reviewed
Feb 6, 2017
| @@ -40,6 +40,13 @@ protected function setUp() | |||
| $this->_conn->getConfiguration()->setSQLLogger($this->_sqlLoggerStack); | |||
| } | |||
|
|
|||
| protected function tearDown() | |||
| { | |||
| if ($this->_conn->isTransactionActive()) { | |||
There was a problem hiding this comment.
What happens if we have nested transactions?
e64551f to
4f1f176
Compare
Ocramius
approved these changes
Feb 7, 2017
|
Backported to 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently discovered a hard to debug issue where I was writing functional tests and suddenly the testsuite was hanging. After hours of debugging I found out that a previous test, involving transactions, failed inside a transaction and was affecting all subsequent tests as the transaction was marked as "rollback only" and still active. As we are mainly using a shared connection for performance reasons, this can get quite nasty.
I added a
tearDownmethod to the base functional test case that checks, whether a transaction is active and rolls it back if that is the case.