[DBAL-2555] Fix date and dat 8000 etimetz type mapping on Oracle #2612
Conversation
| @@ -102,7 +102,7 @@ protected function _getPortableTableColumnDefinition($tableColumn) | |||
|
|
|||
| $dbType = strtolower($tableColumn['data_type']); | |||
| if (strpos($dbType, "timestamp(") === 0) { | |||
| if (strpos($dbType, "WITH TIME ZONE")) { | |||
| if (strpos($dbType, "with time zone")) { | |||
There was a problem hiding this comment.
Since this seems to be something that the DB engine doesn't guarantee, strtolower() should be used (or at least case insensitive matching).
There was a problem hiding this comment.
Test probably also needed with it, but unsure if practical
There was a problem hiding this comment.
Have a look at line 193 ;)
But besides that you reminded me that I forgot a unit test case for the mapping issue in the platform which I added now.
There was a problem hiding this comment.
This is is covered by the functional test case btw. Not sure how else to test this :>
There was a problem hiding this comment.
Dammit, didn't read that, thanks :-)
| @@ -102,7 +102,7 @@ protected function _getPortableTableColumnDefinition($tableColumn) | |||
|
|
|||
| $dbType = strtolower($tableColumn['data_type']); | |||
| if (strpos($dbType, "timestamp(") === 0) { | |||
| if (strpos($dbType, "WITH TIME ZONE")) { | |||
| if (strpos($dbType, "with time zone")) { | |||
There was a problem hiding this comment.
Dammit, didn't read that, thanks :-)
| @@ -412,13 +412,19 @@ public function testAlterTableNotNULL() | |||
| $this->assertEquals($expectedSql, $this->_platform->getAlterTableSQL($tableDiff)); | |||
| } | |||
|
|
|||
| /** | |||
| * @group DBAK-2555 | |||
|
|
|
Backported via 8a13144 |
Fixes #2555
Oracle's
DATEtype was erroneously mapped to Doctrine'sDateTimetype. Although I wonder why nobody ever complained about that until now, the fix looks straight forward and also complies to what we have documented.Additionally the instrospection of
DateTimeTzTypewas wrong and has been fixed (wrong case in type comparison).Tests pass locally.