8000 Remove GIT submodule entries and use `autoload-dev` for the test suite by Tobion · Pull Request #917 · doctrine/dbal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove GIT submodule entries and use a 8000 utoload-dev for the test suite #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 24, 2015
Merged

Remove GIT submodule entries and use autoload-dev for the test suite #917

merged 6 commits into from
Oct 24, 2015

Conversation

Tobion
Copy link
Contributor
@Tobion Tobion commented Oct 17, 2015
  1. remove obsolete entries from gitmodules which was forgotten in Remove unused git submodules #876
  2. composer.lock is not part of the repo, so its useless in gitattributes
  3. DoctrineTestCase is not used and is a remnant pre-split
  4. use autoload-dev completely instead of an init script, complement to Moved Doctrine\Tests namespace to composer autoload-dev #770 and add travis cache and fix apcu installation cache#98
  5. add travis cache. before: ran for 56 min 40 sec. after: ran for 46 min 58 sec
  6. setUp and tearDown are meant to be protected

@Tobion Tobion changed the title Remove submodule entries & use autoload-dev Remove submodule entries & improve test setup Oct 17, 2015
Tobion
Tobion reviewed Oct 17, 2015
View reviewed changes
tests/Doctrine/Tests/TestInit.php
*/

error_reporting(E_ALL | E_STRICT);
date_default_timezone_set('UTC');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this workaround is fixed: travis-ci/travis-ci#2523

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still relevant for folks testing locally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that doesn't belong to the test setup. it's random a random value that has nothing to to with the tests. for testing locally its part of the php setup otherwise it would fail for every project of those people anyway. not just dbal.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but the php defaults are... a mess :-P

deeky666 added a commit that referenced this pull request Oct 24, 2015
@deeky666
Merge pull request #917 from Tobion/remove-submodule-entries
c83a43c 
Remove submodule entries & improve test setup
@deeky666 deeky666 merged commit c83a43c into doctrine:master Oct 24, 2015
@deeky666
Copy link
Member

@Tobion awesome, thanks!

@Tobion Tobion deleted the remove-submodule-entries branch October 24, 2015 12:16
@doctrinebot doctrinebot mentioned this pull request Dec 6, 2015
Closed
@deeky666 deeky666 added this to the 2.6 milestone Jan 5, 2016
@deeky666 deeky666 self-assigned this Jan 5, 2016
@Ocramius Ocramius changed the title Remove submodule entries & improve test setup Remove GIT submodule entries and simplify test setup Jul 22, 2017
@Ocramius Ocramius changed the title Remove GIT submodule entries and simplify test setup Remove GIT submodule entries and use autoload-dev for the test suite Jul 22, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@deeky666 deeky666

Labels
Improvement Test Suite
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Tobion @deeky666 @Ocramius
0