Fix test suite on windows: skip on missing extensions, correct path flags #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1306 We use Jira to track the state of pull requests and the versions they got |
| @@ -314,7 +315,8 @@ public function testConnectionExceptionSqLite($mode, $exceptionClass) | |||
| public function getSqLiteOpenConnection() | |||
| { | |||
| return array( | |||
| array(0000, '\Doctrine\DBAL\Exception\ConnectionException'), | |||
| // mode 0 is considered read-only on Windows | |||
| array(0000, '\\' !== DIRECTORY_SEPARATOR ? '\Doctrine\DBAL\Exception\ConnectionException' : '\Doctrine\DBAL\Exception\ReadOnlyException'), | |||
There was a problem hiding this comment.
I'd rather not infer the host-OS based on the directory-separator. Maybe look at the PHP_OS constant instead? I've seen other projects check the presence of the PHP_WINDOWS_VERSION_BUILD constant as well.
There was a problem hiding this comment.
+1 we should check it with PHP constants.
|
@deeky666 ping |
|
@Tobion thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #718