8000 add `requiresSQLCommentHint` in `DateIntervalType` by vbartusevicius · Pull Request #899 · doctrine/dbal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add requiresSQLCommentHint in DateIntervalType #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2015
Merged

add requiresSQLCommentHint in DateIntervalType #899

merged 2 commits into from
Sep 5, 2015

Conversation

vbartusevicius
Copy link
Contributor

According to comment #854 (comment)

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-1288

We use Jira to track the state of pull requests and the versions they got
included in.

@vbartusevicius vbartusevicius mentioned this pull request Aug 28, 2015
Merged
@deeky666
Copy link
Member

@v-bartusevicius thanks for the addition. We need at least a unit test case for the newly added method. Also I would like to have the functional test suite extended to verify that the mapping is working correctly now. A test case should be added here

@vbartusevicius
Copy link
Contributor Author

@deeky666 - I did something here... not sure what as tests are skipped locally.
If You could provide me some more information on what You want me to extend in DbalFunctionalTestCase (or elsewhere), I would try to implement that.

@billschaller
Copy link
Member

@v-bartusevicius I think he's referring to https://github.com/doctrine/dbal/blob/master/tests/Doctrine/Tests/DBAL/Functional/TypeConversionTest.php

@deeky666 deeky666 merged commit 69963f6 into doctrine:master Sep 5, 2015
deeky666 added a commit that referenced this pull request Sep 5, 2015
@deeky666
Merge pull request #899 from v-bartusevicius:patch-1
f45d030 
requiresSQLCommentHint in DateIntervalType
@deeky666
Copy link
Member
deeky666 commented Sep 5, 2015

@v-bartusevicius merged manually with an additional test added. Thanks!

@vbartusevicius vbartusevicius deleted the patch-1 branch September 7, 2015 11:52
@doctrinebot doctrinebot mentioned this pull request Dec 6, 2015
Closed
@Ocramius Ocramius added this to the 2.6 milestone Jul 22, 2017
@Ocramius Ocramius changed the title requiresSQLCommentHint in DateIntervalType add requiresSQLCommentHint in DateIntervalType Jul 22, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@deeky666 deeky666

Labels
Bug Schema Definition Schema Introspection Type Mapping Types
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@vbartusevicius @doctrinebot @deeky666 @billschaller @Ocramius
0