Remove redundant Connection#connect() calls
#810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1161 We use Jira to track the state of pull requests and the versions they got |
| * | ||
| * @throws \Doctrine\DBAL\DBALException | ||
| */ | ||
| public function prepare($statement) | ||
| { | ||
| $this->connect(); |
There was a problem hiding this comment.
are you sure about that ? I'm quite sure that preparing a statement requires being connected
There was a problem hiding this comment.
Yes, Statement::__construct also calls Connection::connect() via Connection::getWrappedConnection()
|
Looks sane to me /cc @deeky666 |
|
👍 |
|
@rosier thanks! |
Connection#connect() calls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a few unneeded calls to
Connection::connect()