[DBAL-1082] Fix SchemaTool does not generate SQL for MySQL unsigned float #749
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1083 We use Jira to track the state of pull requests and the versions they got |
|
Also added support for unsigned decimal fields |
| public function getDecimalTypeDeclarationSQL(array $columnDef) | ||
| { | ||
| $declaration = parent::getDecimalTypeDeclarationSQL($columnDef); | ||
| return $declaration . $this->_getCommonIntegerTypeDeclarationSQL($columnDef); |
There was a problem hiding this comment.
this would allow to mark a float or a decimal field as autoincrement, which is wrong
There was a problem hiding this comment.
Good point, I've fixed it now.
| */ | ||
| private function getUnsignedDeclaration(array $columnDef) | ||
| { | ||
| return (isset($columnDef['unsigned']) && $columnDef['unsigned']) ? ' UNSIGNED' : ''; |
There was a problem hiding this comment.
this can be simplified using return !empty($columnDef['unsigned']) ? ' UNSIGNED' : '';
| public function getDecimalTypeDeclarationSQL(array $columnDef) | ||
| { | ||
| $declaration = parent::getDecimalTypeDeclarationSQL($columnDef); | ||
| return $declaration . $this->getUnsignedDeclaration($columnDef); |
|
Needs SQL generation test cases. Also a functional test case in |
|
Merged manually, thx @dchesterton ! |
|
No worries, thanks for adding the tests. |
Fix for http://www.doctrine-project.org/jira/browse/DBAL-1082