8000 Use latest stable sqlsrv extensions by morozov · Pull Request #6992 · doctrine/dbal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use latest stable sqlsrv extensions #6992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2025
Merged

Use latest stable sqlsrv extensions #6992

merged 2 commits into from
Jun 13, 2025

Conversation

morozov
Copy link
Member
@morozov morozov commented Jun 12, 2025 •
edited
Loading

The nightly builds are currently failing on PHP 8.5-dev and pdo_sqlsrv:

Could not install pdo_sqlsrv-5.12.0beta1 on PHP 8.5.0-dev

This PR attempts to relax the sqlsrv and pdo_sqlsrv version constraints on CI to allow installing the latest stable version (which is currently 5.12.0). The extension version was last pinned in #4875 but we should un-pin them once a newer stable release is available.

The above nightly build output is actually weird:

Run shivammathur/setup-php@v2
  with:
    php-version: 8.5
    extensions: pdo_sqlsrv-5.10.0beta1
    coverage: pcov
    ini-values: zend.assertions=1
    tools: pecl
    ini-file: production
  env:
    fail-fast: true
/usr/bin/bash /home/runner/work/_actions/shivammathur/setup-php/v2/src/scripts/run.sh

==> Setup PHP
✓ PHP Installed PHP 8.5.0-dev (32c6ac9133d586c9c259cf98bf88037da80fcb9a)

==> Setup Extensions

==> Setup pdo_sqlsrv-5.12.0beta1

The requested extension version is 5.10.0beta1 but the one being installed is 5.12.0beta1.

We want to remove this constraint anyways. But if it doesn't help, I will file an issue with shivammathur/setup-php.

@morozov morozov added this to the 3.9.5 milestone Jun 12, 2025
@morozov morozov closed this Jun 12, 2025
@morozov morozov reopened this Jun 12, 2025
@morozov morozov marked this pull request as ready for review June 12, 2025 23:44
@morozov morozov requested a review from greg0ire June 12, 2025 23:44
@morozov morozov force-pushed the sqlsrv-latest-stable branch from 527da0f to 6a42ef6 Compare June 12, 2025 23:46
@morozov morozov closed this Jun 13, 2025
@morozov morozov reopened this Jun 13, 2025
@morozov morozov force-pushed the sqlsrv-latest-stable branch from 6a42ef6 to 5ddb325 Compare June 13, 2025 04:51
@morozov
Copy link
Member Author
morozov commented Jun 13, 2025

Something's wrong with GitHub Actions. The PR workflow doesn't trigger for a reopened PR, after a force push and even for a another new PR.

@greg0ire
Copy link
Member

We need to add the file you modified to this at least this list:

dbal/.github/workflows/continuous-integration.yml

Line 8 in 5bbe026

- .github/workflows/continuous-integration.yml

@morozov morozov force-pushed the sqlsrv-latest-stable branch from 5ddb325 to 31dfed9 Compare June 13, 2025 06:20
@morozov
Copy link
Member Author
morozov commented Jun 13, 2025

@greg0ire thanks! Given the recent GCP outage and the GitHub Actions incident, I thought this might be related.

@greg0ire
Copy link
Member

Yeah that's the first thing I checked as well, then I went 💡 when seeing the list of changed files 🙂

@morozov morozov merged commit 671a368 into doctrine:3.9.x Jun 13, 2025
51 checks passed
@morozov morozov deleted the sqlsrv-latest-stable branch June 13, 2025 06:27
@morozov
Copy link
Member Author
morozov commented Jun 13, 2025

The nightly build is eventually green!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
CI pdo_sqlsrv sqlsrv
Projects
None yet
Milestone
3.9.5
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @greg0ire
0