Refactor GitHub Actions workflows #6946
Conversation
f9ed1dd to
075c68d
Compare
075c68d to
3f40fa3
Compare
| os: | ||
| - ubuntu-24.04 | ||
| php-version: | ||
| - '8.5' |
There was a problem hiding this comment.
should this use the nightly keyword to reduce maintenance work for that workflow ?
There was a problem hiding this comment.
If that's the same, yes.
There was a problem hiding this comment.
the difference is that nightly will automatically mean PHP 8.6 after the release of PHP 8.5.0 (it always refers to the master branch of PHP).
Actually, 8.5 currently installs the nightly PHP version as 8.5 is not released yet: https://github.com/shivammathur/setup-php?tab=readme-ov-file#tada-php-support
to me, nightly is exactly the intent we want in this nightly.yml job, to avoid having to remember to update it every year.
There was a problem hiding this comment.
Yeah, that was my understanding. Using nightly sounds good. It's more expressive and requires less maintenance.
The problem
If a build with unstable dependencies (e.g. a development PHP version) fails, it fails the entire job (example).
The solution
Minor changes
oci8andpdo_ocihave been combined in a single one with theextensionparameter. This is consistent with the rest of the jobs.dependencyparameter has been renamed todependency-versionsto match the one fromramsey/composer-installibm-db2job has been renamed todb2(the product name is Db2); themssqlone has been renamed tosqlserver(this is quite common and matches the platform name).TODO