8000 Remove handling unuique constraint column names as associative array by morozov · Pull Request #6549 · doctrine/dbal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove handling unuique constraint column names as associative array #6549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2024
Merged

Remove handling unuique constraint column names as associative array #6549

merged 1 commit into from
Oct 14, 2024

Conversation

morozov
Copy link
Member
@morozov morozov commented Oct 14, 2024 •
edited
Loading
Q A
Type cleanup

The dual format serves no purpose and creates ambiguity. It is supported for unique constraints but not for any other schema objects.

8000 morozov added this to the 4.3.0 milestone Oct 14, 2024
@derrabus
Copy link
Member

Looking at the constructor of Doctrine\DBAL\Schema\UniqueConstraint, I doubt that passing columns as keys actually works. Maybe that's just dead code here?

@morozov morozov changed the title Deprecate passing unuique constraint column names as associative array Remove handling unuique constraint column names as associative array Oct 14, 2024
@morozov morozov force-pushed the deprecate-associative-unique-constraint-column-names branch from 253d2d6 to 300c0aa Compare October 14, 2024 15:17
@morozov
Copy link
Member Author
morozov commented Oct 14, 2024

@derrabus you're right. I was under the impression that this method would convert the associative array to the numeric one and pass down the line but it passes the original value. So yeah, dead code.

@derrabus
Copy link
Member

Nice catch!

@derrabus derrabus merged commit 6322f42 into doctrine:4.3.x Oct 14, 2024
90 of 91 checks passed
@morozov morozov deleted the deprecate-associative-unique-constraint-column-names branch October 14, 2024 23:34
derrabus added a commit that referenced this pull request Oct 21, 2024
@derrabus
Merge branch '4.3.x' into 5.0.x
0c0c25c 
* 4.3.x:
  Create stubs instead of mocks (#6564)
  [Bug] Query Cache mangled if saved by-reference (#6552)
  test: remove ->expects(self::any())
  Fix typo in PostgreSql documentation reference
  fix
  Acknowledge the existence of 3.10 (#6553)
  Simplify tracking implicitly created indexes
  Remove handling unuique constraint column names as associative array (#6549)
  test: cover nested transactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Improvement Schema
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @derrabus
0