8000 Deprecations by beberlei · Pull Request #4535 · doctrine/dbal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Deprecations #4535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Mar 27, 2021
Merged

Deprecations #4535

merged 27 commits into from
Mar 27, 2021

Conversation

beberlei
Copy link
Member
@beberlei beberlei commented Mar 6, 2021 •
edited
Loading

Turns all the possible deprecated APIs into using the doctrine/deprecations API.

This includes deprecations on everything that can be done with code at runtime and is missing only the deprecation of fetch methods on the Statement class, which need this PR #4529 for forwards compatibility to suggest a migration from Statement::fetch* to Connection::executeQuery->fetch*()

@beberlei beberlei mentioned this pull request Mar 6, 2021
Merged
@beberlei beberlei marked this pull request as ready for review March 7, 2021 10:11
@beberlei beberlei requested review from morozov and greg0ire March 7, 2021 10:11
morozov
morozov reviewed Mar 7, 2021
View reviewed changes
Copy link
Member
@morozov morozov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Would it be possible to rebase the "Housekeeping: psalm" commit and address these issues by those commits that introduce them? Otherwise, we'll have a broken state in between.

morozov
morozov previously approved these changes Mar 7, 2021
View reviewed changes
@beberlei beberlei changed the base branch from 2.12.x to 2.13.x March 8, 2021 08:49
@beberlei beberlei dismissed morozov’s stale review March 8, 2021 08:49

The base branch was changed.

@beberlei beberlei added this to the 2.13.0 milestone Mar 8, 2021
morozov
morozov requested changes Mar 11, 2021
View reviewed changes
@beberlei
Copy link
Member Author

I have updated 5d20e3c for the CompositeExpression deprecation into one commit, because i needed to add a few flags that trigger or not depending on who is the caller. This is quite annoying and I am wondering about doctrine/deprecations#4 in that context.

@morozov
Copy link
Member
morozov commented Mar 11, 2021 •
edited
Loading

doctrine/deprecations#4 doesn't look like a proper solution to the problem. It shouldn't be necessary for a library to suppress its own calls to its own deprecated APIs. In fact, not calling a certain method because it's deprecated may be a BC break on its own because somebody may have extended/implemented this method, and their extension is no longer effective. So not reporting deprecated calls within the library should be the default behavior.

morozov
morozov previously approved these changes Mar 11, 2021
View reviewed changes
morozov
morozov reviewed Mar 20, 2021
View reviewed changes
Copy link
Member
@morozov morozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i went over each call again and converted quite a few back to using trigger.

That's quite a few but I think we can do better. Please see the comments.

@beberlei beberlei mentioned this pull request Mar 21, 2021
Merged
@beberlei
Copy link
Member Author

Failure is fixed in deprecatios 0.5.3 but i cannot retrigger the appveyor build.

morozov
morozov reviewed Mar 21, 2021
View reviewed changes
Copy link
Member
@morozov morozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure is fixed in deprecatios 0.5.3 but i cannot retrigger the appveyor build.

It warrants a bump of the Deprecations version.

Looks good! Just needs the changes in the last few commits moved under the corresponding original commits.

morozov
morozov previously approved these changes Mar 22, 2021
View reviewed changes
greg0ire
greg0ire reviewed Mar 23, 2021
View reviewed changes
beberlei added 12 commits March 27, 2021 18:56
@beberlei
[doctrineGH-3935] Add deprecation trigger for EchoSQLLogger.
74f4a28
@beberlei
[doctrineGH-3595] Trigger deprecation messages for Sharding APIs.
69a67af
@beberlei
[doctrineGH-3851] Trigger deprecation for ExpressionBuilder::andX/orX
d0b88d5
@beberlei
[doctrineGH-3844] Add deprecation message for CompositeExpression::ad…
7bcd6eb 
…d/addMultiple
@beberlei
[doctrineGH-3837] Trigger deprecation for QueryBuilder::select/addSel…
6b90962 
…ect/groupBy/addGroupBy with array argument.
@beberlei
[doctrineGH-3580] Several deprecation triggers.
d314a78
@beberlei
[doctrineGH-3554] Trigger deprecation for passing user provided PDO i…
f3e971a 
…nstance.
@beberlei
[doctrineGH-3572] Deprecation trigger for LoggerChain::addLogger
7f777ae
@beberlei
[doctrineGH-3316] Deprecate Configuration::get/setFilterSchemaAssetsE…
b620d18 
…xpression().
@beberlei
[doctrineGH-3255] Trigger deprecation for Type::getDefaultLength
9ee8278
@beberlei
[doctrineGH-3258] Trigger deprecation for Type::__toString().
6a736f1
@beberlei
[doctrineGH-4049] Trigger deprecation message for Statement::closeCursor
5a85231
@beberlei beberlei merged commit ad31968 into doctrine:2.13.x Mar 27, 2021
@beberlei beberlei deleted the Deprecations branch March 27, 2021 19:42
@github-actions github-actions bot mentioned this pull request Mar 30, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morozov morozov morozov approved these changes

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@beberlei @morozov @greg0ire
0