Upgrade Psalm to its latest version #4222
Conversation
6b44573 to
61cb2af
Compare
61cb2af to
220d524
Compare
What should be done about that error? We can either widen the type in interface, but the description says it is supposed to be a |
Let's suppress for now. This API was attempted to be fixed for a couple of years now and it's really questionable per se. |
220d524 to
7bbc71f
Compare
| @@ -10,12 +10,12 @@ class Connection extends PDOConnection | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function quote($value, $type = ParameterType::STRING) | |||
There was a problem hiding this comment.
Let's use $value everywhere. The fact that only input needs to be quoted is $1M misconception.
| @@ -52,13 +52,13 @@ public static function assertValidIdentifier($identifier) | |||
| /** | |||
| * {@inheritDoc} | |||
| */ | |||
| public function getSubstringExpression($value, $position, $length = null) | |||
| public function getSubstringExpression($value, $from, $length = null) | |||
It cannot be fixed without a BC break
| @@ -384,11 +384,11 @@ public function getListSequencesSQL($database) | |||
| /** | |||
| * {@inheritDoc} | |||
| */ | |||
| protected function _getCreateTableSQL($table, array $columns, array $options = []) | |||
| protected function _getCreateTableSQL($tableName, array $columns, array $options = []) | |||
There was a problem hiding this comment.
This is against the approach taken in #4172:
Argument names have been simplified where possible (e.g.
dropTable($tableName)→dropTable($name)).
Unless we're dealing both with a table and a name in the same context, there's no much point in being too specific IMO.
| @@ -1105,9 +1105,9 @@ public function getDateTimeTzFormatString() | |||
| /** | |||
| * {@inheritDoc} | |||
| */ | |||
| public function getEmptyIdentityInsertSQL($quotedTableName, $quotedIdentifierColumnName) | |||
There was a problem hiding this comment.
The "quoted" attribute should stay as is. It's a rabbit hole but it has its meaning. I can provide more details if necessary.
7bbc71f to
ae046fe
Compare
| * @param mixed[][] $columns | ||
| * @param mixed[] $options | ||
| * | ||
| * @return string[] | ||
| */ | ||
| protected function _getCreateTableSQL($tableName, array $columns, array $options = []) | ||
| protected function _getCreateTableSQL($name, array $columns, array $options = []) |
There was a problem hiding this comment.
Ah this must a reason why the tests fail… $name is already taken
ae046fe to
b062513
Compare
There was a problem hiding this comment.
Should the Psalm version constraint be updated as well? Otherwise, looks good.
|
Sure, let's prevent accidental downgrades 👍 |
b062513 to
b5e1599
Compare
No description provided.