Fix WhereInWalker description to better describe the behaviour of this class #9268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change the verb "replace" with "append" to better describe the behaviour of this class
derrabus
requested changes
Dec 28, 2021
Co-authored-by: Alexander M. Turek <me@derrabus.de>
Co-authored-by: Alexander M. Turek <me@derrabus.de>
derrabus
approved these changes
Jan 9, 2022
derrabus
added a commit
that referenced
this pull request
Jan 9, 2022
* 2.10.x: Fix WhereInWalker description to better describe the behaviour of this class (#9268)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 9, 2022
* 2.11.x: Leverage generic ObjectManagerDecorator (doctrine#9312) Fix WhereInWalker description to better describe the behaviour of this class (doctrine#9268) Regenerate Psalm baseline Update Psalm baseline for Persistence 2.3 (doctrine#9349) Support readonly properties for read operations (doctrine#9316)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the verb "replace" with "append" to better describe the behavior of this class. As you can see in lines from 105 to 140 the
$AST->whereClauseis not replaced with the IN condition, but the IN condition is appended.This is not a detail since the verb "replace" generates confusion and in Issue #9042 we thought that there was a bug in the code.