8000 Test for Second level cache with Version, DDC #7067 by wtorsi · Pull Request #7069 · doctrine/orm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test for Second level cache with Version, DDC #7067 #7069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2018
Merged

Test for Second level cache with Version, DDC #7067 #7069

merged 2 commits into from
Feb 17, 2018

Conversation

wtorsi
Copy link
@wtorsi wtorsi commented Feb 16, 2018

No description provided.

@Ocramius
Copy link
Member

@wtorsi thanks! Linking #7067

@lcobucci lcobucci force-pushed the master branch 2 times, most recently from dfa263a to 9480093 Compare February 17, 2018 17:01
@lcobucci lcobucci self-assigned this Feb 17, 2018
@lcobucci lcobucci added this to the 2.6.1 milestone Feb 17, 2018
lcobucci
lcobucci approved these changes Feb 17, 2018
View reviewed changes
Copy link
Member
@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wtorsi nice job!

I've applied some small fixes on the patch and it LGTM 👍

@lcobucci
Copy link
Member

I'll just wait for #7076 to fix the build and rebase this branch to ensure that everything still works.
< 8000 div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container d-none">

‘Andrey Lukin’ added 2 commits February 17, 2018 18:38
@lcobucci
Add test for L2C using optimistic locks
35d8c87 
As explained in doctrine#7067, fields with `@ORM\Version` annotation were not
being added to L2C cached data.
@lcobucci
Add version fields into L2C data
38032c1
@lcobucci lcobucci merged commit 65ebade into doctrine:master Feb 17, 2018
@lcobucci
Copy link
Member

@wtorsi 🚢 thanks!

lcobucci added a commit that referenced this pull request Feb 17, 2018
@lcobucci
Merge branch 'backport/fix/l2c-version' into 2.6
794c770 
Backporting #7069
7826
@lcobucci lcobucci mentioned this pull request Feb 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcobucci lcobucci lcobucci approved these changes

Assignees

@lcobucci lcobucci

Labels
Bug
Projects
None yet
Milestone
2.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@wtorsi @Ocramius @lcobucci
0